Phase 2: replace dict-style quant_config access with LayerQuantSpec a…#274
Draft
thpereir wants to merge 1 commit intothpereir/quark_quant_layerfrom
Draft
Phase 2: replace dict-style quant_config access with LayerQuantSpec a…#274thpereir wants to merge 1 commit intothpereir/quark_quant_layerfrom
thpereir wants to merge 1 commit intothpereir/quark_quant_layerfrom
Conversation
…cross all models and ops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cross all models and ops
Motivation
Following up DeepSeek R1 enablement with per layer quantization support this converts all other models to use the same structured quantization config instead of a dict.
This PR depends on both #236 and #268
Technical Details
resolve(prefix)handles exclude-list, per-layer overrides, pattern matching, and global fallback in one call with documented priority. Less error prone than previous approach of accessing the dict. What wasquant_config.get_layer_quant_config(f"{prefix}.fused_qkv_a_proj")becomesquant_config.resolve(prefix)QuantizationConfig.__init__directly.Test Plan
Test Result
Submission Checklist